Dual-funding spec edits, cleanup #4410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niftynei
force-pushed
the
nifty/spec-clean
branch
2 times, most recently
from
aab2c26 to
e6e01c9
Compare
We're punting on PODLE's for v1 of dual-funded channels
We consolidate to the latest/singular RFC patch for dual-funding, so there's just a single patchfile for the change. Plus we move back to the opener setting the desired feerate, the accepter merely declines to participate if they disagree with the set rate.
> If the peer's revocation basepoint is unknown (e.g. `open_channel2`), > a temporary `channel_id` should be found by using a zeroed out basepoint > for the unknown peer.
The receiving node: ...
- MUST fail the channel if:
- the `witness_stack` weight lowers the effective `feerate`
below the agreed upon transaction `feerate`
The maximum inputs and outputs are capped at 252. This effectively fixes the byte size of the input and output counts on the transaction to one (1).
niftynei
force-pushed
the
nifty/spec-clean
branch
from
e6e01c9 to
3ef059b
Compare
rustyrussell
approved these changes
Mar 9, 2021
| u32 funding_feerate_max; | ||
| u32 funding_feerate_min; | ||
| u32 funding_feerate_best; | ||
| u32 funding_feerate_per_kw; |
There was a problem hiding this comment.
I can't remember why we decided on this. I guess simplicity, and to mirror RBF where you need to decide whether to contribute anyway?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There've been some spec changes etc. This updates all 'dual-funding' related spec references to the latest spec proposal lightning/bolts#851.
Notable notes:
open_channel2(0'd out basepoint for peer)Built atop of #4399, new commits start at b8806ba
Changelog-None.