Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clightning: compatibility issue with v24.11 #321

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

YusukeShimizu
Copy link
Contributor

@YusukeShimizu YusukeShimizu commented Oct 3, 2024

Resolves a compatibility issue with clightning.
v24.11 and later versions where the allow-deprecated-apis option may be nested within a configs object of ListConfigs.

Now correctly parses the configuration to determine if deprecated APIs are allowed, ensuring compatibility with both older and newer clightning versions.

Fixes: #320

Resolves a compatibility issue with clightning
v24.11 and later versions where the allow-deprecated-apis
option may be nested within a configs object in the
configuration file.

Now correctly parses the configuration to
determine if deprecated APIs are allowed, ensuring
compatibility with both older and newer clightning
versions.
@YusukeShimizu YusukeShimizu marked this pull request as ready for review October 3, 2024 02:54
@grubles
Copy link
Collaborator

grubles commented Oct 3, 2024

The peerswap plugin now starts when running with CLN master but prints this new error. Is another new API deprecation/removal causing it?

2024-10-03T15:17:52.764Z INFO    plugin-peerswap: peerswap initialized
2024-10-03T15:17:53.434Z DEBUG   lightningd: channel_gossip: no longer in startup mode
2024-10-03T15:17:53.460Z INFO    lightningd: JSON COMMAND sendcustommsg: Invalid parameter node_id (should be a node id): token '""'
2024-10-03T15:17:53.462Z DEBUG   plugin-peerswap: poll_service: could not send msg to : -32602:node_id: should be a node id: invalid token (see logs for details)

@YusukeShimizu
Copy link
Contributor Author

The error seems to be occurring when sending a custom message for polling.
It's unclear whether this is due to deprecation or removal.

I don't think the failure of the poll will result in an immediate impact.

Once a new version of cln is released on nix, I plan to run integration tests to verify.

@grubles
Copy link
Collaborator

grubles commented Oct 6, 2024

Ok I tested a swap using v24.08.1 and master. The poll_service message doesn't seem to break swaps AFAICT.

ACK 663acfd

@YusukeShimizu YusukeShimizu merged commit 513f0c6 into master Oct 8, 2024
8 checks passed
@YusukeShimizu YusukeShimizu deleted the cln-v24-11-compatibility branch October 8, 2024 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

peerswap can't read CLN >24.08 listconfig output
2 participants