Create explicit empty and null values for some types #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMO these are different than f.e. the Default impls on TxOut etc, because these types actually in many actual production cases want to be set to the empty or none value. As opposed to Default on other types that only exist to aid in test scenarios or so to avoid having to set the fields.
delta1
approved these changes
Aug 2, 2023
apoelstra
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO these are different than f.e. the Default impls on TxOut etc, because these types actually in many actual production cases want to be set to the empty or none value. As opposed to Default on other types that only exist to aid in test scenarios or so to avoid having to set the fields.