Improve performance of sequence parallel gather, scatter, and reduce #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bclyang
force-pushed
the
improve-seq-parallel-perf
branch
from
c7b2926
to
53d0ae8
Compare
haileyschoelkopf
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the performance of sequence parallel gather, scatter, and reduce by using
reduce_scatter_tensorandall_gather_into_tensorwhen possible.WandB before: https://wandb.ai/brandony/neox/runs/wcim8pf6?nw=nwuserbrandony
WandB after: https://wandb.ai/brandony/neox/runs/gkaoomq5?nw=nwuserbrandony
From the plot, goes from 15.7e12 flops to 17.3e12 flops, with baseline at 18e12 flops.
