log_samples File name too long. Need truncation or override #1454 FIX #2384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shortened filename creation by hashing model_args to avoid overly long filenames in log_samples. Added logic to hash model_args using MD5 and generate manageable filenames, ensuring unique but shorter output names. Also refactored the logic for constructing the output file path.
kroc99
requested review from
haileyschoelkopf,
lintangsutawika and
baberabb
as code owners
|
|
added hashlib import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shortened filename creation by hashing model_args to avoid overly long filenames in log_samples. Added logic to hash model_args using MD5 and generate manageable filenames, ensuring unique but shorter output names. Also refactored the logic for constructing the output file path.