Use output json instead of metadata for Cromwell #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchim
changed the title
jdidion
changed the title
|
@ruchim what ever happened to this new command line option? I still don't see it (as of Cromwell 54). |
|
hey @jdidion -- the PR was closed: broadinstitute/cromwell#5420 (comment) I'm happy to resurface but the reason it was initially closed was that when I made the PR, pytest had already worked around it and we weren't sure if it would get usage. |
|
I would definitely appreciate this feature. Of course it's up to the Cromwell team to decide if it's broadly useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
** DO NOT MERGE ** -- dependent on a version of Cromwell that doesn't yet exist (likely Cromwell 49).
There's now an option in the Cromwell run mode command line to publish the outputs as a json in a location specified by the user. This pull request leverages that change.
Additional Consideration: Metadata is a large file and holds a ton of data, so we could not read the metadata file at all unless workflow failed and its important to extract a failure message and more.