Skip to content

Commit

Permalink
Fix TestBigReporR.setUp info message
Browse files Browse the repository at this point in the history
Changes that fix the message itself:

- Add a missing space between words (two parts were concatenated,
  with no space at the edge of either).

- Capitalize "GitPython" since that is the repo and project name.

Changes that improve how the message is produced:

- Make the entire literal part of the string the format string,
  instead of formatting the first part and concatenating the second
  part.

- Pass the format string and k_env_git_repo variable as separate
  arguments to logging info, so the logging machinery takes care of
  substituting it for %s, rather than doing the substitution.
  • Loading branch information
EliahKagan committed Oct 23, 2023
1 parent c527b8f commit cc0e0d9
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions test/performance/lib.py
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ def setUp(self):
repo_path = os.environ.get(k_env_git_repo)
if repo_path is None:
logging.info(
("You can set the %s environment variable to a .git repository of" % k_env_git_repo)
+ "your choice - defaulting to the gitpython repository"
"You can set the %s environment variable to a .git repository of your"
" choice - defaulting to the GitPython repository",
k_env_git_repo,
)
repo_path = osp.dirname(__file__)
# end set some repo path
Expand Down

0 comments on commit cc0e0d9

Please sign in to comment.