Skip to content

Commit

Permalink
Remove outdated git_daemon_launched Windows info
Browse files Browse the repository at this point in the history
This removes the Windows-specific information in the warning
message in git_daemon_launched.

After the associated functionality was updated in gitpython-developers#1684 and the
warning message was abridged accordingly, the functionality was
updated again in gitpython-developers#1697, causing the message to be outdated and no
longer helpeful (since having git-daemon.exe in a PATH directory is
no longer necessary or useful), without any corresponding change to
the message.
  • Loading branch information
EliahKagan committed Oct 24, 2023
1 parent 720e4bb commit faa19ac
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions test/lib/helper.py
Original file line number Diff line number Diff line change
Expand Up @@ -213,14 +213,6 @@ def git_daemon_launched(base_path, ip, port):
and setting the environment variable GIT_PYTHON_TEST_GIT_DAEMON_PORT to <port>
"""
)
if is_win:
msg += textwrap.dedent(
R"""
On Windows,
the `git-daemon.exe` must be in PATH.
For MINGW, look into \Git\mingw64\libexec\git-core\, but problems with paths might appear."""
)
log.warning(msg, ex, ip, port, base_path, base_path, exc_info=1)

yield # OK, assume daemon started manually.
Expand Down

0 comments on commit faa19ac

Please sign in to comment.