Skip to content

Commit

Permalink
Remove inactive username_password_not_available test
Browse files Browse the repository at this point in the history
This is cleanup related to GitoxideLabs#1644, which further complicated the
attributes on the `#[ignore]`d `username_password_not_available`
test with an empty that was build (but never run) whenever the
`expectrl` tests of `gix-prompt` were not built. Instead of keeping
its attributes more complicated and maintaining an expectation that
they continue to be updated along with the `target_os` support for
`expectrl`'s `ptyprocess` dependency, this removes that empty test.

The purpose of the test case that this removes is unclear, and it
may not have value anymore. It is unclear in part because actual
interaction to provide a username and password is likely to work on
some systems for which the related tests that use `expectrl` are
not being built. But this empty test case might be read to say
otherwise.

See also the related discussion at:
GitoxideLabs#1644 (review)
  • Loading branch information
EliahKagan committed Oct 24, 2024
1 parent 35d4d9f commit 1fc1471
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions gix-prompt/tests/prompt.rs
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,4 @@ mod ask {
p.expect("\" password with space \"").unwrap();
p.expect(expectrl::Eof).unwrap();
}

#[test]
#[cfg(not(any(target_os = "linux", target_os = "freebsd", target_os = "macos")))]
#[ignore]
fn username_password_not_available() {}
}

0 comments on commit 1fc1471

Please sign in to comment.