Skip to content

Commit

Permalink
Change i686 job to i686-unknown-linux-gnu, run in container
Browse files Browse the repository at this point in the history
The previous approach did not work because musl dependencies were
not installed. (32-bit `-gnu` dependencies would also not be
installed, in that non-container environment.)

Since this is switching to a container, it may as well target the
OS of the container.

The previous reasoning for not (also?) having this 32-bit test use
`GIX_TEST_IGNORE_ARCHIVES=1` no longer applies, but that is not
done at this time.
  • Loading branch information
EliahKagan committed Nov 13, 2024
1 parent 1d243f2 commit 9613618
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -147,21 +147,23 @@ jobs:
test-32bit:
runs-on: ubuntu-latest

env:
TARGET: i686-unknown-linux-musl
container: i386/debian:stable-slim

steps:
- name: Prerequisites
run: |
apt-get update
apt-get install --no-install-recommends -y build-essential ca-certificates cmake curl git jq libssl-dev pkgconf
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
- uses: dtolnay/rust-toolchain@stable
with:
toolchain: stable
targets: ${{ env.TARGET }}
toolchain: stable-i686-unknown-linux-gnu # Otherwise it may misdetect based on the amd64 kernel.
- uses: Swatinem/rust-cache@v2
- uses: taiki-e/install-action@v2
with:
tool: nextest
- name: Test (nextest)
run: cargo nextest run --target "$TARGET" --workspace --no-fail-fast
run: cargo nextest run --workspace --no-fail-fast

test-32bit-cross:
runs-on: ubuntu-latest
Expand Down

0 comments on commit 9613618

Please sign in to comment.