Iter9 #8
Closed
Iter9 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 19, 2023 13:29
for to range
arttet
suggested changes
Dec 1, 2023
There was a problem hiding this comment.
Please add the codecov report
https://about.codecov.io/blog/getting-started-with-code-coverage-for-golang/
internal/agent/uploader/uploader.go
Outdated
| @@ -94,3 +114,89 @@ func (u *Uploader) SendCounterMetrics(metrics map[string]int64) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (u *Uploader) sendMetricsJSON(url string, metrics metrics.Metrics) error { | |||
There was a problem hiding this comment.
It seems this function should work with data as bytes
internal/agent/uploader/uploader.go
Outdated
| @@ -94,3 +114,89 @@ func (u *Uploader) SendCounterMetrics(metrics map[string]int64) error { | |||
| } | |||
| return nil | |||
| } | |||
|
|
|||
| func (u *Uploader) sendMetricsJSON(url string, metrics metrics.Metrics) error { | |||
There was a problem hiding this comment.
Suggested change
| func (u *Uploader) sendMetricsJSON(url string, metrics metrics.Metrics) error { | |
| func (u *Uploader) sendMetricsJSON(url string, metrics []byte) error { |
internal/agent/uploader/uploader.go
Outdated
| } | ||
| }() | ||
|
|
||
| switch resp.Header.Get("Content-Encoding") { |
There was a problem hiding this comment.
It would be better if it is in a middleware
| c.Set(logger, log) | ||
| c.Next() | ||
|
|
||
| if err := log.Sync(); err != nil && (!errors.Is(err, syscall.EBADF) && !errors.Is(err, syscall.ENOTTY)) { |
There was a problem hiding this comment.
Suggested change
| if err := log.Sync(); err != nil && (!errors.Is(err, syscall.EBADF) && !errors.Is(err, syscall.ENOTTY)) { | |
| if err := log.Sync(); err != nil { |
There was a problem hiding this comment.
uber-go/zap#328
проблема zap sync на маке, но если не паниковать,то можно и без этого обойтись)
added 2 commits
December 3, 2023 16:50
…for uoloader for client json requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.