Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build with ParaView in CI on Ubuntu. #527

Merged
merged 1 commit into from
Aug 19, 2024
Merged

Conversation

mmuetzel
Copy link
Contributor

@mmuetzel mmuetzel commented Aug 15, 2024

This enables ParaView in the CI on Ubuntu.

The ubuntu-latest label is still pointing to Ubuntu 22.04. Unfortunately, there is a package conflict that prevents installing ParaView on the runner:

Some packages could not be installed. This may mean that you have
requested an impossible situation or if you are using the unstable
distribution that some required packages have not yet been created
or been moved out of Incoming.
The following information may help to resolve the situation:

The following packages have unmet dependencies:
 python3-paraview : Conflicts: python3-vtk9 but 9.1.0+really9.1.0+dfsg2-3build1 is to be installed
E: Error, pkgProblemResolver::Resolve generated breaks, this may be caused by held packages.
Error: Process completed with exit code 100.

That package conflict is resolved in Ubuntu 24.04. Runner images with that version of Ubuntu are already hosted as a beta by GitHub: actions/runner-images#9848

For the time being, pin the runner image to ubuntu-24.04. That part of the change should be reverted some time after the ubuntu-latest label starts pointing to ubuntu-24.04 (so the CI won't be stuck at an eventually old version of Ubuntu).

@raback
Copy link
Contributor

raback commented Aug 16, 2024

I wonder whether any paraview library is needed here. To my recollection "WITH_PARAVIEW" only means that you can launch paraview directly from ElmerGUI (menu & button) but this is just a system command. To be honest, the "WITH_PARAVIEW" could be there always since almost everybody uses that.

@mmuetzel
Copy link
Contributor Author

mmuetzel commented Aug 16, 2024

Good point. I was confused by the following:

#ifdef EG_PARAVIEW
"<P>This version of ElmerGUI has been linked "
"against ParaView visualization software.<BR>"
"<A HREF='https://www.paraview.org/'>https://www.paraview.org</A></P>"
#endif

But afaict, ElmerGUI isn't actually linked against ParaView. It just starts it as a separate process.

I force pushed a change that enables ParaView everywhere but doesn't install the program itself. IIUC, it isn't actually needed that ParaView is installed to be able to build the respective parts of the code.

@raback raback merged commit 5aa95ac into ElmerCSC:devel Aug 19, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants