Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for aarch64-apple-darwin #137

Closed
repi opened this issue Nov 15, 2020 · 6 comments · Fixed by #157
Closed

Add support for aarch64-apple-darwin #137

repi opened this issue Nov 15, 2020 · 6 comments · Fixed by #157
Labels
enhancement New feature or request

Comments

@repi
Copy link
Contributor

repi commented Nov 15, 2020

Did a quick test build for it and seems the main issue is or rpmalloc crate which is lacking support (EmbarkStudios/rpmalloc-rs#11). We could for now disable the custom global allocator for now for this target

@repi repi added the enhancement New feature or request label Nov 15, 2020
@repi repi changed the title Fix building for aarch64-apple-darwin Add support for aarch64-apple-darwin Nov 15, 2020
@badboy
Copy link
Contributor

badboy commented Mar 16, 2021

Just ran into this. Would you accept a PR that disables that dependency on aarch64-apple-darwin? I can prepare one tomorrow.

@repi
Copy link
Contributor Author

repi commented Mar 16, 2021

We probably should just switch to the mimalloc crate which we already use on on all targets (including aarch64-apple-darwin) in other projects.

A PR with that would be most welcome!

@badboy
Copy link
Contributor

badboy commented Mar 16, 2021

Oh, even easier. I can do that too!

@badboy
Copy link
Contributor

badboy commented Mar 16, 2021

Question though: why does this crate even need a custom allocator? Is it that allocation-heavy that it really benefits much from a non-system one?

@Jake-Shadle
Copy link
Member

I think it was primarily to speed up x86_64-unknown-linux-musl since its allocator was pretty terrible wrt parallelization and it's easier to just use the same allocator for all targets (until we hit issues like this).

@repi
Copy link
Contributor Author

repi commented Mar 16, 2021

Yes I think that was the original issue, and maybe also that on Windows it was really slow with the system allocator that made an actual impact.

badboy added a commit to badboy/cargo-about that referenced this issue Mar 16, 2021
This now allows to build on aarch64-apple-darwin (M1/Arm Apple machines)

Fixes EmbarkStudios#137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants