-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for aarch64-apple-darwin #137
Comments
Just ran into this. Would you accept a PR that disables that dependency on aarch64-apple-darwin? I can prepare one tomorrow. |
We probably should just switch to the A PR with that would be most welcome! |
Oh, even easier. I can do that too! |
Question though: why does this crate even need a custom allocator? Is it that allocation-heavy that it really benefits much from a non-system one? |
I think it was primarily to speed up |
Yes I think that was the original issue, and maybe also that on Windows it was really slow with the system allocator that made an actual impact. |
This now allows to build on aarch64-apple-darwin (M1/Arm Apple machines) Fixes EmbarkStudios#137
Did a quick test build for it and seems the main issue is or rpmalloc crate which is lacking support (EmbarkStudios/rpmalloc-rs#11). We could for now disable the custom global allocator for now for this target
The text was updated successfully, but these errors were encountered: