Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: MSRV is defacto 1.81.0 while advertised as 1.70.0 #720

Closed
Wumpf opened this issue Nov 15, 2024 · 0 comments · Fixed by #721
Closed

Bug: MSRV is defacto 1.81.0 while advertised as 1.70.0 #720

Wumpf opened this issue Nov 15, 2024 · 0 comments · Fixed by #721
Labels
bug Something isn't working

Comments

@Wumpf
Copy link

Wumpf commented Nov 15, 2024

Describe the bug

MSRV is advertised as 1.70.0:
https://github.com/EmbarkStudios/cargo-deny/blob/main/Cargo.toml#L18

However, in 0.16.2 one of the dependencies causes a higher required rust version.

Running in an environment with rust-toolchain file yields:

 error: failed to compile `cargo-deny v0.16.2`, intermediate artifacts can be found at `/tmp/cargo-installmuEfF3`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  rustc 1.79.0 is not supported by the following package:
    twox-hash@2.0.1 requires rustc 1.81

Didn't hit this with 0.16.1 - the dependency updates in 0.16.2 caused this

To reproduce

  • create a rust toolchain file with
[toolchain]
channel = "1.79.0"
  • install cargo deny: cargo install --locked cargo-deny@0.16.2

cargo-deny version

0.16.2

What OS were you running cargo-deny on?

None

Additional context

No response

@Wumpf Wumpf added the bug Something isn't working label Nov 15, 2024
@Wumpf Wumpf changed the title Bug: MSRV is 0.18.0 Bug: MSRV is defacto 1.81.0 while advertised as 1.70.0 Nov 15, 2024
Jake-Shadle added a commit that referenced this issue Nov 15, 2024
teh-cmc pushed a commit to rerun-io/rerun that referenced this issue Nov 15, 2024
Causes our ci to fail because we're on an older Rust version than what
is required by 0.16.2

I'm pretty sure this happened unintentionally, see:
* EmbarkStudios/cargo-deny#720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant