Add evil crates to deny by default. #177
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, this should be done via the advisory database, the template is not a good place for those for a number of reasons. By default, all checks are run if you don't specify a specific one, so that should not be a concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Propose to disallow certain crates by default. These crates should never appear in any even vaguely sane dependency graph. There might be other candidates.
An alternative is to deal with this through the advisory. It seems a better approach, but AFAICT that requires a manual opt in with
cargo deny check advisorieswhich is unfortunate.Advisories (not yet merged at time of this writing):
fake-staticneeds advisory rustsec/advisory-db#207