Add aarch64-unknown-linux-gnu support #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jake-Shadle
approved these changes
Aug 3, 2022
|
Should add a build test to the CI for this target since it is distinct from both x86_64 linux and aarch64 android. |
|
Not sure how to actually test the new workflows pre merge, tried act but that couldn't even run the rustup action edit: see that action-rs supports cross. Will try that tomorrow instead |
Nehliin
force-pushed
the
aarch64-linux-support
branch
from
cdcd114 to
d041cc4
Compare
|
FYI actions/runner-images#5930 for the android failure |
tgolsson
approved these changes
Aug 4, 2022
|
oh I was just about to push an attempt to fix android, I'll open a separate pr for that then |
|
Should be fixed by this: #155 (debug build just passed, just had to update release builds to match it) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Ampere Altra Arm64. Added extra run script since we already have a separate for android (this needs
-fsigned-char) and didn't want to over compilcate the bash scriptsfollow up of: #153