Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audit android-activity v0.4.1 #94

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Audit android-activity v0.4.1 #94

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions audits.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,6 +885,23 @@ criteria = "safe-to-deploy"
version = "1.0.0"
notes = "No unsafe usage or ambient capabilities. No functionality in it beyond a #[test]. "

[[audits.android-activity]]
who = "Robert Bragg <opensource@embark-studios.com>"
criteria = "safe-to-deploy"
version = "0.4.1"
notes = """Some unsafe usage for JNI/FFI, such as implementing extern \"C\" functions for
NativeActivity and to use the `ndk_sys` FFI bindings for the Android NDK libraries.

The GameActivity backend depends on around 2k lines of third-party C/C++ code from Google
as well as around 500 lines of C++ code for the GameText (input method) support.
The C/C++ code is compiled with the `cc` crate.

Although I have reviewed all of the C/C++ code for GameActivity + GameText there
could be unknown soundness issues in there or potentially in any of the Android
NDK APIs used, which are generally also implemented in C/C++.

Written by Robert Bragg who now works at Embark Studios.
"""

# ------------------------------------------------------------------------------------------
# third party crates that we haven't audited, but we trust the author and release process of
Expand Down