-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend glam
support up to version 0.24.0
.
#1038
Conversation
This looks like it might be an issue upstream in |
I suspect this is blocked on this PR getting into a release (whether cc @bitshifter ( |
If I patch glam to latest main the problem goes away. |
Make sure to run Also, remember to mark the commit as "ready for review" and ping me to look at once, once it's 100% ready. |
Sorry. I had forgotten about this PR 😓 |
This seems to work for us now. |
crates/spirv-std/Cargo.toml
Outdated
@@ -12,7 +12,7 @@ spirv-std-types.workspace = true | |||
spirv-std-macros.workspace = true | |||
bitflags = "1.2.1" | |||
num-traits = { version = "0.2.14", default-features = false, features = ["libm"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
num-traits = { version = "0.2.14", default-features = false, features = ["libm"] } | |
num-traits = { version = "0.2.15", default-features = false, features = ["libm"] } |
... this is all it takes to make 0.23
work, too, I'm so sorry for not noticing this earlier!
(EDIT: unresolved this to leave it visible as an explanation)
Co-authored-by: Eduard-Mihai Burtescu <eddyb@lyken.rs>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do the range thing now that we know raising the num-traits
dependency is enough to support 0.23
, and don't forget to add a CHANGELOG entry along the lines of "relaxing glam
version requirements" or something (i.e. we should specify the range we support, not just say we updated).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(sorry for the back & forth, I'll apply these suggestions myself to land this)
Btw, one of the reasons we can keep using a range is that we actually do have a bit of testing, from: That is, |
0.24.0
glam
support up to version 0.24.0
.
We would like update glam version to match other dependencies.