Refactor spirv-builder to build codegen and sysroot itself #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XAMPPRocky
force-pushed
the
vuild-system
branch
from
415a45b
to
bbee964
Compare
Closed
XAMPPRocky
force-pushed
the
vuild-system
branch
16 times, most recently
from
f8f7e0a
to
31257ef
Compare
XAMPPRocky
force-pushed
the
vuild-system
branch
from
b0b9ff3
to
3604fb7
Compare
DJMcNab
reviewed
Nov 19, 2020
XAMPPRocky
force-pushed
the
vuild-system
branch
from
f9c957d
to
bce0c81
Compare
This comment has been minimized.
This comment has been minimized.
XAMPPRocky
force-pushed
the
vuild-system
branch
from
bce0c81
to
82889e7
Compare
|
rust-lang/cargo#8874 (comment) Is relevant and might help solve our windows woes. |
XAMPPRocky
force-pushed
the
vuild-system
branch
3 times, most recently
from
662b8d8
to
006bd9f
Compare
XAMPPRocky
force-pushed
the
vuild-system
branch
from
1271791
to
1305ca7
Compare
Closed
Closed
|
Going to close this for now, as the artifact dependency RFC for cargo was merged, and if we did want to go down this route I'd need to rebase it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces building
rustc_codegen_spirvandspirv-unknown-unknownwith cargo in spirv-builder, with building each as a separate step. Currently this is actually slower as the tests rebuild those artefacts for each invocation, but I'm planning on finishing up the ability to use pre-built artefacts for tests before marking this PR as not a draft.Huge thanks to @DianaNites who added a lot of functionality to
cargo-sysrootto make this possible. 🎉