Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

asm: support sampler and as types #624

Merged
merged 2 commits into from
May 20, 2021
Merged

asm: support sampler and as types #624

merged 2 commits into from
May 20, 2021

Conversation

msiglreith
Copy link
Contributor

Sampler and Acceleration Structure types should get a definition as well when used in an asm! block.
Otherwise, it triggers an ICE down the line e.g as element type of a runtime array:

thread 'rustc' panicked at 'Tried to lookup value that wasn't a type, or has no definition',
E:\Desktop\rust-gpu\crates\rustc_codegen_spirv\src\spirv_type.rs:199:22

@msiglreith msiglreith requested review from eddyb and khyperia as code owners May 19, 2021 19:49
@khyperia khyperia merged commit 75d0d8f into EmbarkStudios:main May 20, 2021
@msiglreith msiglreith deleted the asm-sampler-as branch August 26, 2021 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khyperia khyperia khyperia approved these changes

@eddyb eddyb Awaiting requested review from eddyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@msiglreith @khyperia