Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added read_subpass for SubpassData images, and necessary attrs for it. #643

Merged
merged 6 commits into from
Jun 2, 2021

Conversation

ElectronicRU
Copy link
Contributor

Decided to call the attribute attachment_index since that is shorter than input_attachment_index, and output attachment indices are just locations, so there's no ambiguity.

Tell me if I should add more tests for error messages!

@hrydgard
Copy link
Contributor

hrydgard commented Jun 1, 2021

I think there's a case for keeping "input_" in the name actually, input attachments are such an oddball Vulkan-only thing while attachments are everywhere.

Copy link
Contributor

@khyperia khyperia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just the one thing!

crates/rustc_codegen_spirv/src/codegen_cx/entry.rs Outdated Show resolved Hide resolved
@khyperia khyperia merged commit 985cbed into EmbarkStudios:main Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants