Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Produce spirv-std API docs with all features #653

Merged
merged 1 commit into from
Jun 9, 2021
Merged

Produce spirv-std API docs with all features #653

merged 1 commit into from
Jun 9, 2021

Conversation

XAMPPRocky
Copy link
Member

Fixes issue reported here: #652 (comment)

@XAMPPRocky XAMPPRocky requested review from eddyb and khyperia June 7, 2021 16:01
DJMcNab
DJMcNab approved these changes Jun 8, 2021
View reviewed changes
Copy link
Contributor

@DJMcNab DJMcNab left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if there's any way to validate that it generates the correct thing without merging and seeing what happens, but this looks correct.

@khyperia khyperia merged commit e372029 into main Jun 9, 2021
@khyperia khyperia deleted the doc-all-features branch June 9, 2021 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DJMcNab DJMcNab DJMcNab approved these changes

@khyperia khyperia khyperia approved these changes

@eddyb eddyb Awaiting requested review from eddyb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@XAMPPRocky @khyperia @DJMcNab