asm: implicit label after return or abort terminator #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpUnreachable will be appended as terminator at the end of the asm block.
khyperia
suggested changes
Aug 11, 2021
There was a problem hiding this comment.
This is incorrect, as the user should be able to write multiple blocks in an asm! with normal syntax - with this, they would somehow have to know to not write OpLabel.
Also, please merge this PR into #717, partial fixes from partial PRs leaving glaring issues are very difficult to coordinate and review. (I didn't see this PR when I reviewed 717)
|
Thanks, will look into it again - closing in favor of a single PR #717 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implicitly add an
OpLabelonce a return or abort terminator is found in the asm line stream. This allows to remove the%unused = OpLabelworkaround.Internally, it creates an explicit label instruction and skips the begin_block/end_block mechanism of the rspirv builder due to how the cursor works. I hope handling this transparently is fine, asumming there will be no reference to this label.
Depends on #717
Fixes #564