Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gather all interface OpVariables into OpEntryPoints. #793

Merged
merged 3 commits into from
Nov 4, 2021

Conversation

eddyb
Copy link
Contributor

@eddyb eddyb commented Nov 3, 2021

Opened as draft because the test changes required basing this on #792.

Fixes #748, but the goal became more to get --target-env vulkan1.2 testing going, and the last commit even turns it on in CI (assuming we want that).

@eddyb eddyb force-pushed the gather-all-interface branch from 8d47894 to 75d0621 Compare November 4, 2021 02:07
@eddyb eddyb force-pushed the gather-all-interface branch from 75d0621 to 099ac57 Compare November 4, 2021 08:26
@eddyb eddyb marked this pull request as ready for review November 4, 2021 08:27
@eddyb eddyb requested a review from khyperia as a code owner November 4, 2021 08:27
@eddyb eddyb enabled auto-merge (rebase) November 4, 2021 08:27
Copy link
Contributor

@hrydgard hrydgard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, and confirmed working with our production code. Approved.

@eddyb eddyb merged commit 0414685 into EmbarkStudios:main Nov 4, 2021
@eddyb eddyb deleted the gather-all-interface branch November 4, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spirv-val fails for a module using derived Eq::eq to the target spirv-unknown-vulkan1.2
2 participants