abi: explicitly unpack ScalarPair
newtypes.
#844
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've left good description of the new codepath in a comment in the source, reproduced here:
The user-facing summary is that
MyNewtype<(u32, u32)>
orMyNewtype<&[T]>
(givenstruct MyNewtype<T>(T);
) used to allow reading the single fieldMyNewtype
by value (it would read the two scalars separately), but you couldn't take a reference to the field, as the types would be differentOpTypeStruct
s (with the same fields).On the implementation side, the choice was to keep the existing type identities for anything that itself has the two scalars as separate fields, and only reuse SPIR-V types in the "newtype of something that itself is
ScalarPair
" case, to avoid accidentally allowing more type conflation than necessary.Fixes #836.