Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic unit tests #892

Closed

Conversation

wesselfr
Copy link

@wesselfr wesselfr commented Aug 9, 2022

This PR is aimed to adding unit-tests for the atomics added in #877
In addition, this PR is also adding atomic flags.

@wesselfr wesselfr requested a review from eddyb as a code owner August 9, 2022 12:42
@eddyb
Copy link
Contributor

eddyb commented Aug 9, 2022

There's something wrong going on with the commits, your git config might be set up to have your name and email as = (or something weirder happened).

Also, you seem to have commits from #877, but it doesn't look like you need a rebase, but rather a rebase already left most of these commits much smaller, only the delta from #877?

@wesselfr wesselfr closed this Aug 11, 2022
@wesselfr wesselfr deleted the atomic-unit-tests branch August 11, 2022 08:59
@wesselfr wesselfr restored the atomic-unit-tests branch August 11, 2022 09:02
@wesselfr wesselfr deleted the atomic-unit-tests branch August 11, 2022 09:03
@wesselfr
Copy link
Author

Something went wrong during the rebase, applied my changes again on: #898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants