-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to nightly-2022-09-06 #934
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
suggested changes
Oct 26, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(only posting this review to avoid accidental merging - I'm also pushing some fixes for the const_
macros but will then focus on all
/any
)
eddyb
force-pushed
the
new-nightly
branch
2 times, most recently
from
October 26, 2022 14:45
7a1dc74
to
16863f3
Compare
`const_mat2` is deprecated in `glam`. We need to fix the tests.
eddyb
previously requested changes
Nov 3, 2022
Co-authored-by: Eduard-Mihai Burtescu <eddyb@lyken.rs>
Co-authored-by: Eduard-Mihai Burtescu <eddyb@lyken.rs>
Co-authored-by: Eduard-Mihai Burtescu <eddyb@lyken.rs>
eddyb
approved these changes
Nov 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates
glam
to0.22
. Some tests need to be updated for the removal ofconst_mat2
. With the new release of Rust coming out next week I'd like to keep focus on the nightly itself. I'll create an issue for the tests.