Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Applied workspace inheritance #941

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Applied workspace inheritance #941

merged 2 commits into from
Nov 22, 2022

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Nov 22, 2022

No description provided.

@oisyn oisyn requested review from fu5ha, VZout and eddyb as code owners November 22, 2022 14:34
@oisyn oisyn removed request for fu5ha and VZout November 22, 2022 14:35
eddyb
eddyb reviewed Nov 22, 2022
View reviewed changes
Cargo.toml Show resolved Hide resolved
eddyb
eddyb suggested changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one issue of consistency.

Cargo.toml Show resolved Hide resolved
crates/spirv-builder/Cargo.toml Outdated Show resolved Hide resolved
tests/Cargo.toml Outdated Show resolved Hide resolved
@oisyn oisyn enabled auto-merge (rebase) November 22, 2022 15:19
@oisyn oisyn requested a review from eddyb November 22, 2022 15:27
eddyb
eddyb approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is a difference with default-features = false in workspace vs deps, and spirv-builder had to be moved to the workspace too, that's consistent enough for me!

@oisyn oisyn merged commit 5e7a075 into main Nov 22, 2022
@oisyn oisyn deleted the workspace-inheritance branch November 22, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oisyn @eddyb