Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded compiletest_rs to 0.9.0 #942

Merged
merged 2 commits into from
Nov 24, 2022
Merged

Upgraded compiletest_rs to 0.9.0 #942

merged 2 commits into from
Nov 24, 2022

Conversation

oisyn
Copy link
Contributor

@oisyn oisyn commented Nov 22, 2022

The workspace inheritance is in there as well. I will rebase when those are merged in (done).

@oisyn oisyn requested review from fu5ha, VZout and eddyb as code owners November 22, 2022 15:36
@oisyn oisyn removed request for fu5ha and VZout November 22, 2022 15:50
@oisyn oisyn enabled auto-merge (rebase) November 22, 2022 16:10
Copy link
Contributor

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo the weird final newline thing.

Cargo.toml Outdated Show resolved Hide resolved
@oisyn
Copy link
Contributor Author

oisyn commented Nov 24, 2022

Wait why did android fail all of a sudden?

@oisyn oisyn requested a review from eddyb November 24, 2022 15:10
@eddyb
Copy link
Contributor

eddyb commented Nov 24, 2022

Wait why did android fail all of a sudden?

@oisyn
Copy link
Contributor Author

oisyn commented Nov 24, 2022

Wait why did android fail all of a sudden?

This is why: #945 🙂

@oisyn oisyn merged commit d3a8680 into main Nov 24, 2022
@oisyn oisyn deleted the new-compiletest branch November 24, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants