Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EmitMeshTasksEXT op #26

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Add support for EmitMeshTasksEXT op #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fdc27cc
Add support for EmitMeshTasksEXT
BeastLe9enD Mar 26, 2023
09bc3d3
Update changelog
BeastLe9enD Mar 26, 2023
3f9a4f4
Fix mistake
BeastLe9enD Mar 26, 2023
9d87c2c
Update CHANGELOG.md
BeastLe9enD Mar 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased] - ReleaseDate

### Changed 🛠
- [PR#26](https://github.com/EmbarkStudios/spirt/pull/26) allowed using `OpEmitMeshTasksEXT` as a terminator (by hardcoding it as `Control-Flow`)
- [PR#25](https://github.com/EmbarkStudios/spirt/pull/25) updated SPIRV-headers from 1.5.4 to 1.6.1
- [PR#21](https://github.com/EmbarkStudios/spirt/pull/21) tweaked pretty-printing
styles around de-emphasis (shrinking instead of thinning, for width savings),
Expand Down
1 change: 1 addition & 0 deletions src/spv/spec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -655,6 +655,7 @@ impl Spec {
Some(InstructionCategory::Const)
} else if has_categorical_prefix("OpIgnore")
|| has_categorical_prefix("OpTerminate")
|| inst.opname == "OpEmitMeshTasksEXT"
{
// HACK(eddyb) not category prefixes, but they help with
// working around `Reserved` extensions with control-flow
Expand Down