print: shorten names like type2/func3/etc. to T2/F3/etc.
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddyb
force-pushed
the
print-shorter-names
branch
from
afeecc1 to
a99d2a5
Compare
eddyb
force-pushed
the
print-shorter-names
branch
from
a99d2a5 to
852853c
Compare
eddyb
added a commit
that referenced
this pull request
Jun 18, 2023
…guous. (#36) I've also made the `T1` style use subscripts (so more like `T₁`), because I wasn't happy with the aesthetics of having digits exactly as large as the prefix. The reason I haven't done the subscript change earlier is e.g. `v5` already looks great, and `v₅` and `T₅` still looks different because the `T` is larger than the `v` - the missing trick was to make the subscripts larger when the prefix is uppercase, which seems to balance things out. Comparison (using Kajiya's `assets/shaders/ircache/raster_origins_vs.hlsl`, compiled by DXC, like #39): |[**Before**](https://htmlpreview.github.io/?https://gist.github.com/eddyb/22a1468ce5341e822e95204a91406897/raw/0-before-spirt%252336-raster_origins_vs.hlsl.structured.spirt.html)<br><sub>(click for complete pretty HTML example)</sub>|[**After**](https://htmlpreview.github.io/?https://gist.github.com/eddyb/22a1468ce5341e822e95204a91406897/raw/1-after-spirt%252336-raster_origins_vs.hlsl.structured.spirt.html)<br><sub>(click for complete pretty HTML example)</sub>| |-|-| ||| |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is something I realized while looking at the output of #36, where keywords like
typeorconstwere overly verbose.I've kept the keywords but only on definitions, so e.g.
type T5 = ...is referred to asT5.Comparison (using Kajiya's
assets/shaders/ircache/raster_origins_vs.hlsl, compiled by DXC):(click for complete pretty HTML example)
(click for complete pretty HTML example)