Update to vulkan-sdk-1.3.275 #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jake-Shadle
commented
Feb 2, 2024
Jake-Shadle
commented
- Switch spirv-tools to official repo
- Regenerate includes
- Update build
Jake-Shadle
force-pushed
the
update
branch
3 times, most recently
from
1b62f27 to
7318b4a
Compare
We were using our fork previously, but that is no longer needed (some issue with C++ template bullshit I don't remember) This also makes it clearer which version we are wrapping since we use a release branch that presumably could get patch versions (though I doubt that happens in practice)
It's now required to specify `--output-language=c++` otherwise...compilation fails. Why you need to specify an additional flag to get files that can actually be compiled is an open question
Notably C++17 is now required
So we just rewrite tar + zstd compression in Rust to get what we want on all platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.