Fixed closing arbitrator server #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In current situation client could hang as it's server could be closed before receiving answer. Server is used for receiving all answers. Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
2 tasks
|
Thank you, Dusan! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current situation client could hang as it's server could be closed before receiving answer. Server is used for receiving all answers.
Signed-off-by: Cervenka Dusan cervenka@acrios.com
Pull request
Choose Correct
Describe the pull request
Hi Michal, i noticed that test_arbitrator hangs often. Based on my today debugging i think i found rootcause and solution.
coren0 last erpc function informed second side that tests are over and we can close servers. Then other core sometimes send erpc call to stop core0 server before core0 received answer from last request.
I add new erpc function which is oneway (so no wait for answer) which will start the process with closing servers.
To Reproduce
Rerun tests several times
Expected behavior
No hang
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context