Fixed memcpy for template #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@amgross Do you agree with PR? |
MichalPrincNXP
approved these changes
Mar 7, 2023
amgross
suggested changes
Mar 8, 2023
| @@ -63,13 +63,16 @@ if (({$info.sizeTemp} <= {$info.maxSize}) && ({$info.dataTemp} != NULL)) | |||
| {% if source == "server" || info.useMallocOnClientSide == true %} | |||
| {$indent}{$info.name} = (uint8_t *) erpc_malloc({$info.maxSize} * sizeof(uint8_t)); | |||
| {% if generateAllocErrorChecks == true %} | |||
| {$indent}if (({$info.name} == NULL) && ({$info.sizeTemp} > 0)) | |||
| {$indent}if ({$info.sizeTemp} > 0) | |||
There was a problem hiding this comment.
Still if generateAllocErrorChecks is false the issue will happen, suggest to move this check outside the {% if generateAllocErrorChecks == true %}
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
|
Hi guys, what do you think now? |
amgross
suggested changes
Apr 4, 2023
Signed-off-by: Cervenka Dusan <cervenka@acrios.com>
amgross
approved these changes
Apr 4, 2023
|
If you can next time not force push changes I will appreciate it. |
|
@amgross Sorry for that, i accidentally did commit with amend as i need to do in other project. They do not want a lot of commits. |
|
All fine, |
MichalPrincNXP
approved these changes
Apr 6, 2023
MichalPrincNXP
approved these changes
Apr 6, 2023
|
Thank you for resolving the discussion and providing this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Choose Correct
Describe the pull request
memcpy could have undefined behavior
To Reproduce
Expected behavior
Screenshots
Desktop (please complete the following information):
Steps you didn't forgot to do
Additional context