kick off updateScrollViewHeight after layout pass completes #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahsmartin
reviewed
Aug 26, 2024
| @@ -78,7 +78,11 @@ public final class ExpandingViewController: UIHostingController<EmergeModifierVi | |||
|
|
|||
| public override func viewDidLayoutSubviews() { | |||
| super.viewDidLayoutSubviews() | |||
There was a problem hiding this comment.
Isn't viewDidLayoutSubviews only called after the layout pass has completed? viewWillLayoutSubviews is called before it's completed, but we aren't using that here
There was a problem hiding this comment.
I agree, I find it confusing too... I guess there's an additional layout pass that happens after the one that completed that kicked off the viewDidLayoutSubviews call... but it's pretty conclusive whether it works or not based on this from testing.
Either way, the cause of the issue is some sort of race condition and I think the layoutIfNeeded approach might be more straightforward (and achieve the same thing)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We either do this or call
layoutIfNeededat the top of theupdateScrollViewHeightmethod in order to ensure that the expansion logic doesn't have a race condition with the layout pass