Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to svelte4 #245

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Bump to svelte4 #245

merged 2 commits into from
Jun 30, 2023

Conversation

razshare
Copy link
Contributor

@razshare razshare commented Jun 27, 2023

This pr updates package.json to require svelte4 and replaces SvelteComponentTyped, which is now deprecated in svelte4, with SvelteComponent directly instead, as suggested by the svelte authors.

Feel free to make any edits to the pr.

razshare added 2 commits June 28, 2023 00:27
SvelteComponentTyped is now deprecated in svelte4, authors suggest using SvelteComponent directly instead.
@krishnaTORQUE
Copy link
Collaborator

@tncrazvan
Just 1 question, did you checked from your end, that there is no issue or bug?
E.g. no infinity loop in nested routes or any failed async component?
Thanks

@razshare
Copy link
Contributor Author

@krishnaTORQUE
No, I have only tested the example in the repository by linking it locally with npm link.
I can write more examples in the repository if you want, to check different use cases, I have some time on the weekend.

Let me know, so I know how to organize my weekend.

@krishnaTORQUE
Copy link
Collaborator

That's completely fine. Thanks
I will review & merge.
Thank you so much for the PR.

@krishnaTORQUE krishnaTORQUE merged commit eab61b2 into EmilTholin:master Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants