This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
CVE-2020-14319: Deny mutation operations unless an existing session exists #5091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vbusch
approved these changes
Jul 29, 2020
k-wall
added a commit
that referenced
this pull request
Jul 29, 2020
…xists (#5091) * CVE-2020-14319: Deny mutation operations unless an existing session exists * Disable unit tests (cherry picked from commit 5cf63dd)
k-wall
added a commit
that referenced
this pull request
Jul 29, 2020
(cherry picked from commit 557ebfc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
To guard against a possible CSRF with some older browsers, apply the same-site cookie option strict to the console-server's session cookie, and deny mutation operations for requests that don't already have a session.
Checklist
./documentation/design