Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable and run black formatter #1413

Merged
merged 27 commits into from
Sep 14, 2023
Merged

fix: enable and run black formatter #1413

merged 27 commits into from
Sep 14, 2023

Conversation

johevemi
Copy link
Contributor

Description

Black has not worked automatically in our code for some time. This is now fixed and black formatting has been rn on our python code

References

  • #0000

@cla-bot cla-bot bot added the cla-signed label Sep 12, 2023
@johevemi johevemi changed the title enable and run black formatter fix: enable and run black formatter Sep 12, 2023
@johevemi johevemi marked this pull request as ready for review September 12, 2023 14:01
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #1413 (2243d83) into main (5c61cff) will increase coverage by 14.97%.
Report is 1 commits behind head on main.
The diff coverage is 99.46%.

@@             Coverage Diff             @@
##             main    #1413       +/-   ##
===========================================
+ Coverage   82.99%   97.96%   +14.97%     
===========================================
  Files         225      153       -72     
  Lines        5016     4327      -689     
===========================================
+ Hits         4163     4239       +76     
+ Misses        670       88      -582     
+ Partials      183        0      -183     
Files Changed Coverage Δ
...ergy/transformations/apply_grid_loss_adjustment.py 100.00% <ø> (ø)
...lation_input/schemas/charge_link_periods_schema.py 100.00% <ø> (ø)
...input/schemas/charge_master_data_periods_schema.py 100.00% <ø> (ø)
...lation_input/schemas/charge_price_points_schema.py 100.00% <ø> (ø)
...alculation_input/schemas/imbalance_price_schema.py 100.00% <ø> (ø)
...alculation_output/schemas/energy_results_schema.py 100.00% <ø> (ø)
...ulation_output/schemas/wholesale_results_schema.py 100.00% <ø> (ø)
...ricks/calculation-engine/package/calculator_job.py 84.61% <ø> (ø)
...ation-engine/package/codelists/time_series_type.py 100.00% <ø> (ø)
...lation/energy/test_aggregation_result_formatter.py 100.00% <ø> (ø)
... and 49 more

... and 319 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@BjarkeMeier BjarkeMeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - just a few wishes left as comments

@johevemi johevemi requested a review from a team as a code owner September 14, 2023 07:50
BjarkeMeier
BjarkeMeier previously approved these changes Sep 14, 2023
@johevemi johevemi enabled auto-merge (squash) September 14, 2023 12:11
Copy link
Contributor

@dstenroejl dstenroejl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved workflow files

@johevemi johevemi enabled auto-merge (squash) September 14, 2023 12:52
@johevemi johevemi merged commit 5fa5667 into main Sep 14, 2023
25 checks passed
@johevemi johevemi deleted the enable_black_again branch September 14, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants