Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refac: Remove write wholesale results to HIVE #2962

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

refac: Remove write wholesale results to HIVE #2962

wants to merge 10 commits into from

Conversation

energinet-ajw
Copy link
Contributor

@energinet-ajw energinet-ajw commented Nov 4, 2024 •
edited
Loading

Description

Pull-request quality

  • The title adheres to this guide
  • Tests are written and executed locally
  • Subsystem tests have been tested (by manually deploying to dev_002)

@energinet-ajw energinet-ajw changed the title Updates refac: Remove write wholesale results to HIVE Nov 4, 2024
@energinet-ajw energinet-ajw marked this pull request as draft November 5, 2024 11:30
BjarkeMeier
BjarkeMeier reviewed Nov 5, 2024
View reviewed changes
source/databricks/calculation_engine/package/infrastructure/paths.py Outdated
Comment on lines 145 to 146
WHOLESALE_RESULT_TABLE_NAME = "wholesale_results"
SUCCEEDED_ENERGY_RESULTS_V1_VIEW_NAME = "succeeded_energy_results_v1"
Copy link
Contributor

@BjarkeMeier BjarkeMeier Nov 5, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the whole class?

BjarkeMeier
BjarkeMeier reviewed Nov 5, 2024
View reviewed changes
source/databricks/calculation_engine/package/infrastructure/paths.py
@@ -142,8 +142,6 @@ class HiveOutputDatabase:
"""The folder in the storage account container"""

DATABASE_NAME = "wholesale_output"
WHOLESALE_RESULT_TABLE_NAME = "wholesale_results"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this break the hive migrations? (I anticipate that the value is used for substitution in some migration scripts)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I need to add all table names again because 1) yes, I think it will break existing scripts and 2) the script that deletes the old tables needs to know the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BjarkeMeier BjarkeMeier BjarkeMeier left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@energinet-ajw @BjarkeMeier