add: User identity negotiation #402
Conversation
Enet4
added
A-lib
|
Hello! Thank you for the pull request! It is great to see an initiative towards the integration on authorization mechanisms in DICOM-rs. |
Enet4
added
the
breaking change
There was a problem hiding this comment.
Hello @nicholasrussel! I am adding this contribution as a candidate for DICOM-rs 0.7.0, but we may need a reiteration of the code first. Please see the suggestions inline, and let me know your availability to work on this.
If you also have any ideas for testing the changes in a real scenario, I would be grateful to know. The PACS archives I usually work with do not feature user identity negotiation.
- Remove `Unsupported` - rename SAMLAssertion to `SamlAssertion` - rename JWT to `Jwt` - make UserIdentityType non-exhaustive
Enet4
force-pushed
the
user-identity-negotiation
branch
from
1591a42 to
8057259
Compare
- constrain to at most one user identity negotiation variable set
- declare conflict with other user identity forms - + format code
There was a problem hiding this comment.
Despite there being gaps in the ecosystem for full authentication support, there is interest in expanding the ul crate with the knowledge of user identity parts, plus the extra of making these available in the dicom-storescu tool. This appears to be in order, so I will merge it onto the 0.7 milestone. Much appreciated! 👍
Hello,
Looking for your feedback in adding some of the user identity negotiation options.
In order to keep this minimal, I added the entrypoint into retrieving this data into the existing AccessControl trait. The downside being that it breaks the interface.
Thanks