Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Missing generated Tags #73

Closed
wants to merge 6 commits into from

Conversation

OhFlowi
Copy link
Contributor

@OhFlowi OhFlowi commented Mar 19, 2024

Adds missing <auto-generated /> and [GeneratedCode] to generated files. Also ensures that the generated files are available for inspection (see Before and After).

Before:
Before

After:
After

You always need both:
<auto-generated /> -> for most IDEs, non-roslyn based analyzers and some roslyn based analyzers.
[GeneratedCode] -> for some IDEs and most roslyn-based analyzers.

The original #68 was closed with "fix with commit 95ab4ef", which did not fix every bug.

@OhFlowi OhFlowi changed the title Fix/documentation warnings Missing generated Tags Mar 19, 2024
@OhFlowi OhFlowi changed the title Missing generated Tags FIX: Missing generated Tags Mar 19, 2024
@EngRajabi
Copy link
Owner

I didn't want your extra changes to be messed up. I minimized these changes in the project
eb5796c

@EngRajabi EngRajabi closed this Mar 29, 2024
@OhFlowi OhFlowi deleted the fix/DocumentationWarnings branch March 29, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants