refactor chartJS implementation for web and native to implement onTap
#1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: #1685
So basically i did updated the
onTapfunctionality in this PR last time #1690 for which had some changes in modules/js_widget/lib/src/mobile/js_widget.dart which were being used inFinicityConnectwidget and it broke that part, 2 days back we reverted those changes so finicity would work as it were doing, and refactor theChartJSwidget code to be able to provide support for both Web and Nativ with proper folder structure as well same asFinicityConnectwidget.Code Example and working video on both web and emulator is updated in Issue.