ADR for syncing data to Salesforce #2866
Conversation
| - `+` Kafka supplies tricky retry logic, should be durable | ||
| - `+` If push errors, we still will get data into the system | ||
| - `+` MACPRO already has multiple data sources going into BigMac, MC Contract data would be another | ||
| - `-` adding another system to the sync process is adding complexity, more pieces to fail |
There was a problem hiding this comment.
Additional negatives:
- involves coordination between multiple teams which we don't have bandwidth for
- XL scope - not feasible for short term POC
| - `+` If push errors, we still will get data into the system | ||
| - `+` Would call existing app-api API, same way we've asked ARMS to | ||
| - `-` Not instantaneous, probably can't send Salesforce link in submission email | ||
| - `-` requires writing more code in Salesforce |
There was a problem hiding this comment.
I don't understand why writing implementation in salesforce is a negative. Is this what salesforce team said? I don't see a technical reason to avoid writing code in salesforce for this, do you? Especially if we have skills to do so on team and its the app that will consume the data.
| In order for CMS users to be able to review submissions in Salesforce, all submission need to be in the Salesforce database. We will first get data into Salesforce by calling Salesforce APIS from app-api on every submission. Other data sync strategies may follow. | ||
|
|
||
| ### Decision Drivers | ||
|
|
There was a problem hiding this comment.
I suggest adding can be implemented by end of calendar year to the list. We have serious constraints around time. I think we want to have at least a basic implementation working fairly soon.
|
|
||
| ### Chosen: Push data into Salesforce from app-api on submission | ||
|
|
||
| Salesforce has a few different API options for sending data into its database from outside. We can make a REST call from app-api as part of our submission handler. This will send data into Salesforce immediately at submission time, there will be no gap. On resubmission we will send over the new data. |
There was a problem hiding this comment.
I'd be interested to compare actual scope between option 1 and option 2 from someone on salesfroce team experienced with implementing APIs. For a custom web app, option 1 is considerably lower scope than option 2. I wonder though how much is pre-built already into salesforce for a pub sub approach
|
@macrael I think there is an option missing from the list - pull on-demand. Specifically, Salesforce could pull data from MC-Review on button click "Refresh submissions list". This seems considerably less effort than pub-sub. At the same time, it reduces some of the risks of doing a push on submit approach, which, besides not being extendable if we decide to add in Q&A data, has risks also for ease of testing/validation that pulling data does not. |
Summary
ADR for syncing data to Salesforce. Still under draft, I'm less sure now about going with push initially.
Related issues
https://jiraent.cms.gov/browse/MCR-4553