Refactor app-web OTEL #2886
Open
Refactor app-web OTEL #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This refactors OTEL in
app-web, as we've been having on and off issues around getting traces into New Relic and alerting on them. This refactors how we do things inapp-web. Previously, we had a wrapper component that initialized tracing outside of the component lifecycle and the TraceProvider didn't provide the context. Here we useReact.createContextand have hooks for other components to use.I also fixed up the alert groups in New Relic and tested that we do get a
JSExceptionwhen we trigger the error boundary test in my branch. Those should be available in dev/val/prod as this promotes.Note that there were a few tests that kept failing that I had to clean up with these changes.
Related issues
https://jiraent.cms.gov/browse/MCR-4437