Recreate pg_wal if required in barman-cloud-restore #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthreefoot-edb
approved these changes
Jul 21, 2021
mikewallace1979
approved these changes
Jul 22, 2021
jthreefoot-edb
approved these changes
Jul 22, 2021
If you run barman-cloud-backup on a data directory where pg_wal is a symlink, it doesn't include pg_wal in the uploaded tar files, and the pg_wal directory will not be created if you restore the backup. We fix this by creating pg_wal (or pg_xlog, depending on the version) in the destination directory if it does not exist at the end of the backup. Closes #327
Each tablespace has a name, an oid, and a location (directory), and there is a symbolic link from $PGDATA/pg_tblspc/$oid to the location. barman-cloud-backup uploads a $oid.tar file for each tablespace, and records the properties of each tablespace in backup_info.tablespaces. Until now, barman-cloud-restore knew only how to download $oid.tar and extract its contents to the original location. Here we add a couple of new features: 1. You may optionally specify `--tablespace name:/new/location` to extract a given tablespace to a different location (you can repeat this option multiple times) 2. After downloading and extracting $oid.tar to the desired location, we now recreate the symbolic link from $PGDATA/pg_tblspc/$oid to that directory. Closes #343 Closes #330
amenonsen
force-pushed
the
dev/327-restore-pg_wal
branch
from
791b071
to
3a69225
Compare
jthreefoot-edb
approved these changes
Jul 23, 2021
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run barman-cloud-backup on a data directory where pg_wal is a
symlink, it doesn't include pg_wal in the uploaded tar files, and the
pg_wal directory will not be created if you restore the backup.
We fix this by creating pg_wal in the destination directory if it does
not exist at the end of the backup.
Closes #327