Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance update #184

Merged
merged 10 commits into from
Jul 16, 2023
Merged

Maintenance update #184

merged 10 commits into from
Jul 16, 2023

Conversation

artemisart
Copy link
Contributor

@artemisart artemisart commented Jun 21, 2023

Make pyfunctional compatible and tested on python 3.7 to 3.11 + pypy3.

This PR is a copy of #178, rebased & some deps updated to fix CI & compatibility with pypy3, closes #178.

This branch bumps some versions:

* Python ^3.6 -> ^3.7
* pytest ^2.4 -> ^7.0
* pytest-cov ^2.8.1 -> ^4.0
* covervage <5.0 -> ^5.0
* black 19.10b0 -> ^23.1

Then I ran poetry update in order to ensure that the poetry.lock file was up to date.

Using this configuration I was able to run poetry install without running in to issue #176, which makes me expect that that that should be resolved, but maybe I do not understand that well enough. It is either that, or the fact that they merged an update last week.

I could run poetry run pytest --cov=functional without issues, getting the same coverage as is currently posted on the repository. I am having issues with Travis, which is giving me trouble running the build.

The new version of black suggests small changes in the tests files, namely the removal of the u-strings and minor formatting stuff for powers. As far as I can tell this is fine. Pylint also complains about the u-strings and then some formatting which was being done in python 3.6 style (using .format as opposed to f strings). Pylint also suggests to specifying the file format when using open in the tests. I can inlcude these suggestions in the PR if you would like me to, though they are all warning level messages.

I would like to mention that there is still a travis.sh file in the project root, however as far as I can tell that is from an outdated version of Travis. Would it make sense to remove it in this in this PR?

@codecov
Copy link

codecov bot commented Jul 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (e5eb3d3) 98.08% compared to head (b144963) 98.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #184   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          12       12           
  Lines        2344     2345    +1     
=======================================
+ Hits         2299     2300    +1     
  Misses         45       45           
Impacted Files Coverage Δ
functional/io.py 100.00% <100.00%> (ø)
functional/pipeline.py 98.11% <100.00%> (ø)
functional/test/test_functional.py 99.02% <100.00%> (ø)
functional/test/test_io.py 100.00% <100.00%> (ø)
functional/test/test_streams.py 93.76% <100.00%> (ø)
functional/test/test_util.py 100.00% <100.00%> (ø)
functional/transformations.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Package operations: 0 installs, 11 updates, 3 removals

  • Removing pip (23.1.2)
  • Removing setuptools (67.8.0)
  • Removing wheel (0.40.0)
  • Updating lazy-object-proxy (1.4.3 -> 1.9.0)
  • Updating pluggy (0.13.1 -> 1.2.0)
  • Updating astroid (2.15.5 -> 2.15.6)
  • Updating coverage (7.2.5 -> 7.2.7)
  • Updating isort (5.7.0 -> 5.11.5)
  • Updating mccabe (0.6.1 -> 0.7.0)
  • Updating platformdirs (3.5.1 -> 3.9.0)
  • Updating pytest (7.3.1 -> 7.4.0)
  • Updating typing-extensions (4.6.0 -> 4.7.1)
  • Updating pypandoc (1.5 -> 1.11)
  • Updating pytest-cov (4.0.0 -> 4.1.0)
@artemisart
Copy link
Contributor Author

Updated dependencies for pypy compatibility, CI is green now @EntilZha

@EntilZha EntilZha merged commit a4cd31c into EntilZha:master Jul 16, 2023
8 checks passed
@artemisart artemisart deleted the maintenance branch July 17, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants