Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔀 :: (ENTRY-164) 공지사항 상세조회 기능 추가 #37

Merged
merged 6 commits into from
Apr 13, 2024
Merged

🔀 :: (ENTRY-164) 공지사항 상세조회 기능 추가 #37

merged 6 commits into from
Apr 13, 2024

Conversation

HyunSu1768
Copy link
Member

@HyunSu1768 HyunSu1768 commented Apr 11, 2024 •
edited
Loading

  • Notice 에서 S3에 객체를 올리 때 PATH 를 비즈니스 로직에서 정해주는 부분을 따로 분리한 NoticeS3Service 인터페이스를 만들었습니다.
  • modify notice에서 fileName이 null일 경우 NoContent를 반환하도록 하였습니다.
Screenshot 2024-04-11 at 4 18 19 PM

@linear Linear
Copy link

linear bot commented Apr 11, 2024

ENTRY-164 공지사항 상세조회

@HyunSu1768 HyunSu1768 self-assigned this Apr 11, 2024
@HyunSu1768 HyunSu1768 added 기능 추가 New feature or request 리펙토링 Refactoring is needed labels Apr 11, 2024
@lilseongwon
Copy link
Member

Conflict 고쳐주세요

@HyunSu1768 HyunSu1768 merged commit c5ce75a into develop Apr 13, 2024
1 check passed
@HyunSu1768 HyunSu1768 deleted the feature/entry-164-공지사항-상세조회 branch April 13, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilseongwon lilseongwon lilseongwon approved these changes

@rudeh2926 rudeh2926 rudeh2926 approved these changes

@jyk1029 jyk1029 Awaiting requested review from jyk1029

@rlaisqls rlaisqls Awaiting requested review from rlaisqls

Assignees

@HyunSu1768 HyunSu1768

Labels
기능 추가 New feature or request 리펙토링 Refactoring is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HyunSu1768 @lilseongwon @rudeh2926