Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿ”€ :: (ENTRY-190) ์ฒจ๋ถ€ํŒŒ์ผ ์—ฌ๋Ÿฌ๊ฐœ ์ž…๋ ฅ๋ฐ›์„์ˆ˜ ์žˆ๊ฒŒ ๋ณ€๊ฒฝ #46

Merged
merged 7 commits into from
Jun 27, 2024
Merged

๐Ÿ”€ :: (ENTRY-190) ์ฒจ๋ถ€ํŒŒ์ผ ์—ฌ๋Ÿฌ๊ฐœ ์ž…๋ ฅ๋ฐ›์„์ˆ˜ ์žˆ๊ฒŒ ๋ณ€๊ฒฝ #46

merged 7 commits into from
Jun 27, 2024

Conversation

rudeh2926
Copy link
Member

@rudeh2926 rudeh2926 commented Jun 25, 2024 •
edited
Loading

แ„‰แ…ณแ„แ…ณแ„…แ…ตแ†ซแ„‰แ…ฃแ†บ 2024-06-25 แ„‹แ…ฉแ„’แ…ฎ 9 14 45

@rudeh2926 rudeh2926 self-assigned this Jun 25, 2024
@linear Linear
Copy link

linear bot commented Jun 25, 2024

ENTRY-190 ๊ณต์ง€์‚ฌํ•ญ ์ƒ์„ฑ api ๋ณ€๊ฒฝํ•˜๊ธฐ

lilseongwon
lilseongwon reviewed Jun 26, 2024
View reviewed changes
src/main/kotlin/hs/kr/equus/feed/domain/notice/presentation/dto/response/GetNoticeResponse.kt Outdated
@@ -9,5 +9,5 @@ data class GetNoticeResponse(
val createdAt: LocalDateTime,
val type: NoticeType,
val imageURL: String?,
val attachFileUrl: List<String>?
val attachFileUrl: List<String>? = emptyList()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„๋‹ˆ ์ด๊ฑฐ ๊ฑ not null๋กœ ํ•˜๋ฉด ์•ˆ๋˜๋‚˜? ์™œ ๋ฆฌ์ŠคํŠธ๋ฅผ nullable๋กœ ๋งŒ๋“œ๋Š”๊ฑฐ์ž„?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์ฒจ๋ถ€ํŒŒ์ผ์€ ์žˆ์„์ˆ˜๋„ ์žˆ๊ณ  ์—†์„์ˆ˜๋„ ์žˆ๊ธฐ๋•Œ๋ฌธ์— nullable๋กœ ํ–ˆ์Šต๋‹ˆ๋‹ค

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์•„๋‹ˆ ๊ทธ๋‹ˆ๊นŒ

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—†์œผ๋ฉด ๊ฑ emptyList ๋ฐ˜ํ™˜ํ•˜๋ฉด ๋˜์ž–์•„

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์™œ ๊ตณ์ด listํƒ€์ž…์„ nullable๋กœ ํ•˜๋ƒ๋Š”๊ฑฐ์ง€

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„ต ๋ณ€๊ฒฝํ•˜๊ฒ ์Šต๋‹ˆ๋‹ค

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2b21a00

@rudeh2926 rudeh2926 merged commit dbcc5fe into develop Jun 27, 2024
1 check passed
@rudeh2926 rudeh2926 deleted the feature/entry-190-๊ณต์ง€์‚ฌํ•ญ-์ƒ์„ฑ-api-๋ณ€๊ฒฝํ•˜๊ธฐ branch June 27, 2024 06:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilseongwon lilseongwon lilseongwon approved these changes

@HyunSu1768 HyunSu1768 HyunSu1768 approved these changes

@jyk1029 jyk1029 Awaiting requested review from jyk1029

@rlaisqls rlaisqls Awaiting requested review from rlaisqls

Assignees

@rudeh2926 rudeh2926

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rudeh2926 @lilseongwon @HyunSu1768