🔀 :: (ENTRY-203)공지사항 상세조회 API 변경 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rudeh2926
commented
Jun 30, 2024
rudeh2926
commented
rudeh2926
requested review from
lilseongwon,
jyk1029,
HyunSu1768 and
rlaisqls
as code owners
HyunSu1768
approved these changes
Jun 30, 2024
lilseongwon
reviewed
Jun 30, 2024
| @@ -20,10 +21,13 @@ class QueryDetailsNoticeService( | |||
| val notice = noticeRepository.findByIdOrNull(noticeId) ?: throw NoticeNotFoundException | |||
| val imageURL = notice.fileName?.let { getUrl(it, PathList.NOTICE) } | |||
|
|
|||
| val attachFileUrls = | |||
| val attachFile = | |||
There was a problem hiding this comment.
내가 왜 확인 못했지...싶긴 한데 굳이 generateObjectUrl을 getUrl 함수로 감쌀 필요가 있나 싶음
There was a problem hiding this comment.
attachfile이랑 image에 똑같이 fileUtil.generateObjectUrl 하는것보다 함수로 따로뺴서 하는게 좋다고 생각했기 때문입니다
lilseongwon
reviewed
Jun 30, 2024
| @@ -9,5 +9,10 @@ data class QueryDetailsNoticeResponse( | |||
| val createdAt: LocalDateTime, | |||
| val type: NoticeType, | |||
| val imageURL: String?, | |||
| val attachFileUrl: List<String> = emptyList() | |||
| val attachFile: List<AttachFile> | |||
There was a problem hiding this comment.
attachFiles가 맞을듯 그래도. 타입은 복수형이니까 네이밍 지켜야지
Comment on lines
26
to
30
| AttachFile( | ||
| attachFileUrl = getUrl(it.attachFileName, PathList.ATTACH_FILE), | ||
| attachFileName = it.attachFileName | ||
| ) | ||
| } ?: emptyList() |
There was a problem hiding this comment.
이거 nullcheck 안해도 자연스럽게 emptyList 되지 않나?
There was a problem hiding this comment.
여기다가 주석으로 왜 클래스타입을 List로 변환하는지 설명하는게 좋을듯
lilseongwon
approved these changes
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.