Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calling convention print and mismatch #1125

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Fix calling convention print and mismatch #1125

merged 2 commits into from
Nov 2, 2023

Conversation

jlk9
Copy link
Collaborator

@jlk9 jlk9 commented Nov 2, 2023

No description provided.

@jlk9 jlk9 requested a review from wsmoses November 2, 2023 21:23
@codecov-commenter
Copy link

codecov-commenter commented Nov 2, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (612a575) 76.45% compared to head (35416de) 93.30%.
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1125       +/-   ##
===========================================
+ Coverage   76.45%   93.30%   +16.84%     
===========================================
  Files          27        7       -20     
  Lines        9408      239     -9169     
===========================================
- Hits         7193      223     -6970     
+ Misses       2215       16     -2199     

see 25 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wsmoses wsmoses merged commit d471a8d into main Nov 2, 2023
31 of 42 checks passed
@wsmoses wsmoses deleted the cconvprint branch November 2, 2023 22:00
michel2323 pushed a commit that referenced this pull request Nov 7, 2023
* Fix calling convention print and mismatch

* Use make zero for reverse allocation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants